touch/cp: don't hang preserving timestamps on a FIFO#12758
Open
sylvestre wants to merge 3 commits into
Open
Conversation
sylvestre
force-pushed
the
fifo-utimensat-no-hang
branch
from
1a9781b to
9af2726
Compare
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 5.9%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | cp_recursive_deep_tree[(120, 4)] |
562.5 KB | 615.6 KB | -8.62% |
| ❌ | Simulation | ls_recursive_balanced_tree[(6, 4, 15)] |
49.6 ms | 52.3 ms | -5.2% |
| ❌ | Simulation | ls_recursive_wide_tree[(10000, 1000)] |
33 ms | 34.3 ms | -3.81% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing sylvestre:fifo-utimensat-no-hang (a42d3f1) with main (542e7af)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
filetime::set_file_times opens the file before setting times, which blocks forever on a FIFO with no writer. Add uucore::fs::set_file_times using a path-based utimensat (like GNU), shared by cp and touch.
Use uucore::fs::set_file_times instead of filetime::set_file_times, which opens the destination first and so blocks forever on a FIFO with no writer. Should make test tests/cp/preserve-mode.sh pass
Use uucore::fs::set_file_times instead of filetime, which opens the target first and so blocks forever on a FIFO with no writer. Should make test tests/touch/fifo.sh pass
sylvestre
force-pushed
the
fifo-utimensat-no-hang
branch
from
9af2726 to
a42d3f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.