feat: IonModeBasis GT3b producer payload - #4
Merged
Conversation
- Add IonModeBasis frozen record + ion_mode_basis(...) emitter - Wire invariants: ion-major/axis-minor B, canonical coordinate_frame id, frequency↔column alignment, sign-canonicalised eigenvectors - D3 local-reference gauges: trap_curvature (default) and diagonal_hessian - Serialization-neutral asdict()/as_arrays() with detached array copies - Contract tests + guarded real-consumer round-trip test - Docs/api/CHANGELOG/LOG updates Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Producer half of the ratified cross-repo GT3b handshake with
iontrap-dynamics(taskcards/TC-ion-mode-basis-payload.md). Emits a versioned, serialization-neutralIonModeBasispayload that the sibling'smaterialize_ion_mode_basis(...)validates and turns into its normal→local symplectic mapS. This repo stays classical structural dynamics — no phase-space /S-builder math here.What's included
IonModeBasisrecord +ion_mode_basis(...)emitter (mode_basis.py), pure-functions-over-frozen-records style.B(3N,3N)withB[3i+c,m]=eigenvectors[m,i,c],coordinate_frameemitted as the consumer's canonical identifier (exact-match on the consumer side), frequency↔column alignment, and sign-canonicalised eigenvectors (largest-|component| positive) for reproducibility.trap_curvature(default) anddiagonal_hessian, recorded in tags.asdict()/as_arrays()returning detached array copies + primitive tags (no shared runtime class).ω>0holds even for a hand-built/criticalModeResult.pytest.importorskip) that drivesmaterialize_ion_mode_basis(**payload.asdict()).api.md),CHANGELOG.md,docs/LOG.mdupdated.Verification
ruff check .,mypy,mkdocs build --strictall clean; contract suite green.iontrap-dynamicsconsumer (equal-mass, mixed-species, both gauges, N=2/3/5): materialises, retains tags, builtSsymplectic to|SΩSᵀ−Ω| ≤ 1.6e-15.Notes
schema_version = 1is provisional pending consumer ratification (tracked indocs/LOG.md).to_mode_configs()per-mode seam is unchanged and is not the GT3b handshake.🤖 Generated with Claude Code