fix: make ui.id and vaadin.client.location high-cardinality - #355
Open
caalador wants to merge 3 commits into
Open
fix: make ui.id and vaadin.client.location high-cardinality#355caalador wants to merge 3 commits into
caalador wants to merge 3 commits into
Conversation
ui.id and vaadin.client.location moved from lowCardinalityKeyValue to highCardinalityKeyValue on the request observation. They still reach the span; they no longer reach the timer. The class javadoc now states the timer's tag set explicitly, and the clientLocation javadoc explains why the literal path stays span-only and points at the route tag for templated attribution.
caalador
added a commit
to vaadin/docs
that referenced
this pull request
Aug 17, 2026
caalador
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui.id and vaadin.client.location moved from
lowCardinalityKeyValue to highCardinalityKeyValue
on the request observation.
They still reach the span; they no longer reach the timer. The class javadoc now states the timer's tag set
explicitly, and the clientLocation javadoc explains why the literal path stays span-only and points
at the route tag for templated attribution.
Fixes #348