Drop stapling

[vadimpiven]

No description provided.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
.github/actions/sign-notarize/action.yaml	0% smaller

[gemini-code-assist]

Code Review

This pull request removes the stapling step (xcrun stapler staple) from the macOS signing and notarization workflow. The review feedback points out a potential issue where using printf with arbitrary command output from a JSON log file can fail or corrupt output if % characters are present. It is recommended to safely print the log using echo and cat instead.

[gemini-code-assist]

Using printf with arbitrary command output as the format string can lead to issues if the output contains % characters (which is common in JSON logs, e.g., URL-encoded strings or percentages). This can cause printf to fail or produce garbled output.

Consider printing the header separately and using cat directly to output the log file safely.

            echo "=== Log output ==="
            cat /tmp/notarization_log.json

[greptile-apps]

Greptile Summary

This PR removes the xcrun stapler staple step from the macOS notarization path in the composite GitHub Action. Stapling attaches an offline-verifiable notarization ticket to an artifact, but Apple's stapler tool only supports bundled artifact types (.app, .pkg, .dmg) — not plain executables. Submitting a raw binary to stapler would fail or be a no-op.

• Drops three lines that called xcrun stapler staple \"$BINARY_PATH\" after a successful notarytool submit; notarization itself is unaffected and the binary remains notarized (verified online by Gatekeeper).
• No other logic, inputs, or steps are changed.

Confidence Score: 5/5

Safe to merge — the removed command cannot operate on plain binaries and would have errored if exercised.

The change removes a stapler invocation that only works on macOS bundles/packages, not on the plain binary this action is designed to handle. Notarization itself is untouched; the binary will continue to be accepted by Gatekeeper via online ticket lookup. No other logic is altered.

No files require special attention.

Important Files Changed

Filename	Overview
.github/actions/sign-notarize/action.yaml	Removes the xcrun stapler staple call after macOS notarization; stapling is only valid for .app/.pkg/.dmg bundles, not plain binaries, so this command would have produced an error or been a no-op for the target artifact type.

_{Reviews (1): Last reviewed commit: "Drop stapling" | Re-trigger Greptile}