Skip to content

Don't allow spaces in mcp server endpoints#123

Open
mdeyell-valid-mind wants to merge 5 commits into
mainfrom
mdeyell/gh-115/no-space-mcp
Open

Don't allow spaces in mcp server endpoints#123
mdeyell-valid-mind wants to merge 5 commits into
mainfrom
mdeyell/gh-115/no-space-mcp

Conversation

@mdeyell-valid-mind

@mdeyell-valid-mind mdeyell-valid-mind commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Creating an MCP server with a space in its name (for example "Slack Local") produces an endpoint that clients cannot reach.

To fix this, I added a slug that can be used to select servers. Now when making a mcp server named slack local, it gets an internal slug of slack-local. The db enforces unique slugs.
I also disallow names that consist entirely of dots .

Screenshot 2026-06-29 at 14 40 44
  • endpoint_slug storage on mcp_servers, with a migration that backfills existing servers and handles slug collisions deterministically.
    • Resolver support for looking up servers by endpoint slug as well as by original name.
    • Admin API fields for endpoint_slug and endpoint_url.
    • UI display of the resolved MCP endpoint after create/save and in the server detail panel.
    • Tests covering slug generation, duplicate slug rejection, migration backfill, resolver lookup, and admin API endpoint display.

#115

@mdeyell-valid-mind mdeyell-valid-mind marked this pull request as ready for review June 29, 2026 22:03
@mdeyell-valid-mind mdeyell-valid-mind requested review from even-steven and hunner and removed request for hunner June 29, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants