Add all files for new feature - #3
Open
varunreddyGOPU wants to merge 6 commits into
Open
Conversation
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
| with open('buggy_app.py', 'w') as f: | ||
| f.write(app_code) | ||
| with open('app.log', 'w') as f: | ||
| with open('app_error.log', 'w') as f: |
There was a problem hiding this comment.
Suggested change
| with open('app_error.log', 'w') as f: | |
| with open('app_error.log', 'w', encoding='utf_8') as f: |
UnicodeEncodeError can occur if the text being written to the file contain characters not compatible with the OS's default text encoding because encoding is not set. Explained here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds all files in the folder.