CON-1516: Remove vCPU gate from self-test preflight - #413
Draft
jjziets wants to merge 11 commits into
Draft
Conversation
robballantyne
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I will approve without requesting changes when test image is available
teboholekulo26
approved these changes
Jun 19, 2026
Contributor
Author
|
CON-1531 follow-up pushed in What changed:
Validation:
Local evidence/artifacts:
|
jjziets
force-pushed
the
CON-1516-remove-vcpu-self-test-preflight
branch
from
June 25, 2026 09:25
63f2752 to
f737010
Compare
Contributor
Author
|
Final CON-1531 diagnostic follow-up SHA is now Additional tightening in the final amend:
Latest local validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
offer["cpu_cores"] >= 2 * num_gpus>64direct-port advisory so hosts are only warned when too few direct ports are available5001/udpwhen launching the self-test image and externally probe it after TCP/progressis reachablevastai/test:self-test-cli-1.2.2-cuda-*VAST_SELF_TEST_CLI_VERSIONandVAST_SELF_TEST_CLI_CONTRACT_VERSIONinto the self-test instance--debugging/--debugingliberror-perlScope Note
1.2.2.vastai/test:self-test-cli-1.2.2-cuda-11.8confirmed the bundle includes CLI/API-visible instance evidence such asinstance/daemon.log,instance/container.log, andinstance/show-instance.json.cli_visible_instance_artifacts/includes_cli_visible_instance_artifacts, while host-local artifacts are recorded separately underlocal_host_artifacts/includes_local_host_artifacts.dmesg,journalctl, kaalia logs, or full Docker daemon logs) unless a host-side collection path is used. Exact daemon/Docker startup root-cause mapping still needs daemon-side source/structured error codes or host-side logs.Validation
./.venv/bin/python -m pytest tests/cli/test_self_test_support_bundle.py -q— 9 passed, 1 existing pytest config warning./.venv/bin/python -m pytest tests/cli -q— 321 passed, 1 existing pytest config warninggit diff --checkgraphify update .— updatedgraphify-out/graph.jsonandGRAPH_REPORT.md; skipped HTML because graph has 82,245 nodes53944andvastai/test:self-test-cli-1.2.2-cuda-11.8confirmed CLI/API-visible log artifacts are present andincludes_local_host_artifacts=falseImage Build / Dogfood
push=true.image=vastai/test,tag_prefix=self-test-cli-1.2.2-cuda-,min_cli_version=1.2.2,cuda_version=all.vastai/test:self-test-cli-1.2.2-cuda-11.8,vastai/test:self-test-cli-1.2.2-cuda-13.0, andvastai/test:self-test-cli-1.2.2-cuda-13.3have built/pushed successfully; CUDA 12.8 is still running in the same workflow.