Stop advertising unreleased network volume type in 'show volumes --type' - #474
Closed
sammy-vastai wants to merge 1 commit into
Closed
Stop advertising unreleased network volume type in 'show volumes --type'#474sammy-vastai wants to merge 1 commit into
sammy-vastai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #466. That PR hid the four dedicated network-volume commands (
search network-volumes,create network-volume,list network-volume,unlist network-volume) from--help/completion, but missed a second discovery path: the already-released, always-visiblevastai show volumescommand takes--type local|all|network, and its help text advertised"network"as a valid value.Confirmed against
~/workspace/vast/web: there's no dedicated "show network volume" endpoint — network volume data rides along inside the existing/volumesendpoint via thattypefilter, which is why this didn't show up as a separate hideable command.Fix mirrors #466's approach: stop advertising the value in the help text; don't restrict/block it (no
choices=on the argument), so--type networkstill works for anyone who already knows about it (internal/QA testing unaffected) — discoverability gate, not an access gate.Test plan
poetry run pytest tests/cli— 413 passedvastai show volumes --helpno longer mentions "network"