Skip to content

Hide unreleased network-disk commands from --help - #475

Merged
sammy-vastai merged 1 commit into
masterfrom
hide-network-disk-commands
Jul 27, 2026
Merged

Hide unreleased network-disk commands from --help#475
sammy-vastai merged 1 commit into
masterfrom
hide-network-disk-commands

Conversation

@sammy-vastai

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #466 (network volumes). Network disks aren't released either — show network-disks and add network-disk were still fully visible in vastai --help and tab completion.

Reuses the same HIDDEN_COMMANDS mechanism from #466: discoverability gate only, not an access gate — both commands still run if typed directly.

Test plan

  • poetry run pytest tests/cli — 415 passed
  • Manually verified: neither command appears anywhere in vastai --help; both still parse and run when typed directly

@sammy-vastai
sammy-vastai marked this pull request as ready for review July 25, 2026 00:32
@vastzuby

vastzuby commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

imo should just remove everything related to network volumes, we can always add it from the history

@sammy-vastai

Copy link
Copy Markdown
Contributor Author

imo should just remove everything related to network volumes, we can always add it from the history

Yeah didn't know whether to delete so that's why I tagged some infra/host devs. I think everything network volumes related is now hidden (from --help and autocomplete suggestions). Last pr removed network volume commands and i had missed the 'network disk' related commands. The commands still work if we type them, they're just hidden from users. Should be sufficient, lmk if any concerns

@sammy-vastai
sammy-vastai merged commit 9ae4fff into master Jul 27, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants