Hide unreleased network-disk commands from --help - #475
Merged
Conversation
sammy-vastai
marked this pull request as ready for review
July 25, 2026 00:32
sammy-vastai
requested review from
agustin-vastai,
liam-at-vast and
stackanthony
July 25, 2026 00:32
vastzuby
approved these changes
Jul 27, 2026
Contributor
|
imo should just remove everything related to network volumes, we can always add it from the history |
Contributor
Author
Yeah didn't know whether to delete so that's why I tagged some infra/host devs. I think everything network volumes related is now hidden (from --help and autocomplete suggestions). Last pr removed network volume commands and i had missed the 'network disk' related commands. The commands still work if we type them, they're just hidden from users. Should be sufficient, lmk if any concerns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #466 (network volumes). Network disks aren't released either —
show network-disksandadd network-diskwere still fully visible invastai --helpand tab completion.Reuses the same
HIDDEN_COMMANDSmechanism from #466: discoverability gate only, not an access gate — both commands still run if typed directly.Test plan
poetry run pytest tests/cli— 415 passedvastai --help; both still parse and run when typed directly