chore(logging): Improve datadog logs semantic meaning warning#25608
Open
gwenaskell wants to merge 2 commits into
Open
chore(logging): Improve datadog logs semantic meaning warning#25608gwenaskell wants to merge 2 commits into
gwenaskell wants to merge 2 commits into
Conversation
…ity improvement Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing warning log fired when a DD reserved attribute (e.g. status) needed to be relocated based on its semantic meaning, but the destination field already existed. The message was vague — it didn't identify the source path of the semantically-tagged field, the destination it was being moved to, or which field was being renamed and why.
This PR improves the log by adding source_path, destination_path, and renamed_existing_to fields, making it actionable when triaging unexpected field renames in pipelines that route OpenTelemetry or other structured logs through the Datadog logs sink.
Vector configuration
How did you test this PR?
n/a
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.