Skip to content

Fix issue with names decoding #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KateOrient merged 2 commits into from
Jun 16, 2026
Merged

Fix issue with names decoding #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac33e59
Fix issue with names decoding
ekaterina-chubrick Jun 16, 2026
b4d7398
Comment debug message
ekaterina-chubrick Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/core/catalog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,6 +1798,17 @@ class ExtendedCatalog extends Catalog {
return shadow(this, "structTreeRootObject", structTreeRoot);
}

convertString(str, type) {
try {
return stringToUTF8String(str);
} catch (e) {
/*console.log(
`Failed to convert string "${str}" (${type}) to UTF-8, using safe conversion. Error: ${e}`
);*/
return stringToPDFString(str);
}
}

getTreeElement(el, page, ref) {
try {
// update page for current element
Expand All @@ -1817,8 +1828,8 @@ class ExtendedCatalog extends Catalog {
const roleName = this.getRoleName(el, name);

const treeElement = {
name: name ? stringToPDFString(name) : null,
roleName: roleName ? stringToPDFString(roleName) : null,
name: name ? this.convertString(name, "Name") : null,
roleName: roleName ? this.convertString(roleName, "Role name") : null,
children: this.getTreeElement(el.get("K"), page, el.getRaw("K")),
pageIndex: page,
ref: ref instanceof Ref ? ref : null,
Expand All @@ -1829,7 +1840,7 @@ class ExtendedCatalog extends Catalog {
alt = el.has("ActualText") ? el.get("ActualText") : null;
}
if (typeof alt === "string") {
treeElement.alt = stringToPDFString(alt);
treeElement.alt = this.convertString(alt, "Alt");
}

return treeElement;
Expand Down Expand Up @@ -1903,8 +1914,8 @@ class ExtendedCatalog extends Catalog {
const roleName = this.getRoleName(el, name);

const treeElement = {
name: name ? stringToPDFString(name) : null,
roleName: roleName ? stringToPDFString(roleName) : null,
name: name ? this.convertString(name, "Name") : null,
roleName: roleName ? this.convertString(roleName, "Role name") : null,
children: [],
pageIndex: page,
ref: ref instanceof Ref ? ref : null,
Expand All @@ -1915,7 +1926,7 @@ class ExtendedCatalog extends Catalog {
alt = el.has("ActualText") ? el.get("ActualText") : null;
}
if (typeof alt === "string") {
treeElement.alt = stringToPDFString(alt);
treeElement.alt = this.convertString(alt, "Alt");
}

return treeElement;
Expand Down
Loading