π‘οΈ Sentinel: [CRITICAL/HIGH] Fix Information Leakage via RPC Errors - #74
π‘οΈ Sentinel: [CRITICAL/HIGH] Fix Information Leakage via RPC Errors#74DerUntote wants to merge 1 commit into
Conversation
Sanitized RPC error messages being sent to Discord users to prevent internal path/state leakage. Full errors are now safely logged internally. Co-authored-by: DerUntote <8378077+DerUntote@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Information Leakage via RPC Errors. Internal
bitcoind-rpcdaemon errors (err.message) were being directly relayed back to Discord users viamessage.reply(). This exposes internal paths, sensitive operational details, or backend state to untrusted users.π― Impact: An attacker could exploit invalid commands or edge-case transactions to map the backend structure, understand the exact reason for daemon failures, or gain insight into the node's configuration/balance state.
π§ Fix: Replaced direct
message.reply(err.message)with a genericmessage.reply('An error occurred while processing your request.')across all 9*Tipper.jsmodules. The actualerrobject is now logged internally viaconsole.error(err)for developer debugging. Also appended.catch(console.error)to message deletion to prevent Unhandled Promise Rejections.β Verification:
node -c) on all modified modules to ensure no syntax errors were introduced.PR created automatically by Jules for task 3767126361846864491 started by @DerUntote