Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix Information Leakage via RPC Errors - #74

Open
DerUntote wants to merge 1 commit into
masterfrom
sentinel-fix-information-leakage-3767126361846864491
Open

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix Information Leakage via RPC Errors#74
DerUntote wants to merge 1 commit into
masterfrom
sentinel-fix-information-leakage-3767126361846864491

Conversation

@DerUntote

Copy link
Copy Markdown

🚨 Severity: CRITICAL

πŸ’‘ Vulnerability: Information Leakage via RPC Errors. Internal bitcoind-rpc daemon errors (err.message) were being directly relayed back to Discord users via message.reply(). This exposes internal paths, sensitive operational details, or backend state to untrusted users.

🎯 Impact: An attacker could exploit invalid commands or edge-case transactions to map the backend structure, understand the exact reason for daemon failures, or gain insight into the node's configuration/balance state.

πŸ”§ Fix: Replaced direct message.reply(err.message) with a generic message.reply('An error occurred while processing your request.') across all 9 *Tipper.js modules. The actual err object is now logged internally via console.error(err) for developer debugging. Also appended .catch(console.error) to message deletion to prevent Unhandled Promise Rejections.

βœ… Verification:

  • Formatted all modules with Prettier.
  • Ran syntax validation (node -c) on all modified modules to ensure no syntax errors were introduced.
  • Verified exact diff matches intent.

PR created automatically by Jules for task 3767126361846864491 started by @DerUntote

Sanitized RPC error messages being sent to Discord users to prevent internal path/state leakage. Full errors are now safely logged internally.

Co-authored-by: DerUntote <8378077+DerUntote@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant