π‘οΈ Sentinel: [MEDIUM] Fix internal RPC error leakage - #79
Conversation
Replaced direct discord message.reply() with generic error message, caught and logged internal daemon/RPC errors to console for security. Co-authored-by: DerUntote <8378077+DerUntote@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: The internal daemon/RPC errors from
.sendFromwere being passed directly to discord viamessage.reply(err.message).π― Impact: This could expose infrastructure details, node info, or other unexpected sensitive information when an internal command fails.
π§ Fix: Instead of exposing
err.messagedirectly in the reply, catch it, log it internally for administrators withconsole.error(err);, and return a generic user-facing message like'An internal error occurred.'. Make sure to chain.catch(() => {})onmessage.delete(10000)to prevent uncaught exceptions if the message is deleted before 10s.β Verification: Ran
git diff, syntax checkingnode -c, and auto-formattingnpx prettieron all touched*Tipper.jsfiles.PR created automatically by Jules for task 13790790241772766196 started by @DerUntote