π‘οΈ Sentinel: [CRITICAL/HIGH] Fix internal error leakage in RPC replies - #94
π‘οΈ Sentinel: [CRITICAL/HIGH] Fix internal error leakage in RPC replies#94DerUntote wants to merge 1 commit into
Conversation
Co-authored-by: DerUntote <8378077+DerUntote@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Internal RPC error messages (e.g. from bitcoind-rpc) were being exposed directly to users via
message.reply(err.message)when a transaction failed.π― Impact: This could leak sensitive internal information, including network details, specific failure reasons, or connection paths, which an attacker might use for reconnaissance.
π§ Fix: Replaced
message.reply(err.message)withconsole.error(err); message.reply('An internal error occurred. Please try again later.')across all tipbot modules. This logs the error internally for debugging but returns a generic error message to the user.β Verification: Ran
git diffto verify the replacements andnode -con all modified files to ensure no syntax errors were introduced. Checked the formatting of.jules/sentinel.mdjournal entry.PR created automatically by Jules for task 4144418480542002682 started by @DerUntote