⚡ Bolt: Regex token extraction optimization

.jules/bolt.md

@@ -1,3 +1,6 @@
 ## 2024-05-17 - O(N) lookup optimizations for Discord.js
 **Learning:** Found two O(N) operations in bot.js and module Tipper scripts when looking up members or guild count.
 **Action:** Replaced `bot.guilds.array().length` with `bot.guilds.size` (O(1)) and `message.guild.members.find('id', recipient)` with `message.guild.members.get(recipient)` (O(1)).
+## 2024-05-18 - String split optimization
+**Learning:** Found string split operations for message tokenization in bot.js and tipper modules that allocate intermediate arrays.
+**Action:** Replaced `.trim().split(' ').filter(...)` with `.match(/\S+/g) || []` to efficiently extract non-whitespace tokens.

bot/bot.js

@@ -153,13 +153,13 @@ function checkMessageForCommand(msg, isEdit) {
           return;
         });
     }
-    var cmdTxt = msg.content.split(' ')[0].substring(config.prefix.length);
+    var cmdTxt = (msg.content.match(/\S+/g) || [''])[0].substring(config.prefix.length);
     var suffix = msg.content.substring(
       cmdTxt.length + config.prefix.length + 1
     ); //add one for the ! and one for the space
     if (msg.isMentioned(bot.user)) {
       try {
-        cmdTxt = msg.content.split(' ')[1];
+        cmdTxt = (msg.content.match(/\S+/g) || [])[1];
         suffix = msg.content.substring(
           bot.user.mention().length + cmdTxt.length + config.prefix.length + 1
         );

bot/modules/dogeTipper.js

@@ -19,12 +19,7 @@ exports.tipdoge = {
     paytxfee,
   process: async function (bot, msg, suffix) {
     let tipper = msg.author.id.replace('!', ''),
-      words = msg.content
-        .trim()
-        .split(' ')
-        .filter(function (n) {
-          return n !== '';
-        }),
+      words = msg.content.match(/\S+/g) || [],
       subcommand = words.length >= 2 ? words[1] : 'help',
       helpmsg =
         '__**Dogecoin (DOGE) Tipper**__\nTransaction Fees: **' +

bot/modules/exampleTipper.js

@@ -28,12 +28,7 @@ exports.tipltc = {
     '__**Litecoin (LTC) Tipper**__\nTransaction Fees: **' + paytxfee + '**\n    **!tipltc** : Displays This Message\n    **!tipltc balance** : get your balance\n    **!tipltc deposit** : get address for your deposits\n    **!tipltc withdraw <ADDRESS> <AMOUNT>** : withdraw coins to specified address\n    **!tipltc <@user> <amount>** :mention a user with @ and then the amount to tip them\n    **!tipltc private <user> <amount>** : put private before Mentioning a user to tip them privately.\n\n    has a default txfee of ' + paytxfee,
   process: async function(bot, msg, suffix) {
     let tipper = msg.author.id.replace('!', ''),
-      words = msg.content
-        .trim()
-        .split(' ')
-        .filter(function(n) {
-          return n !== '';
-        }),
+      words = msg.content.match(/\S+/g) || [],
       subcommand = words.length >= 2 ? words[1] : 'help',
       helpmsg =
         '__**Litecoin (LTC) Tipper**__\nTransaction Fees: **' + paytxfee + '**\n    **!tipltc** : Displays This Message\n    **!tipltc balance** : get your balance\n    **!tipltc deposit** : get address for your deposits\n    **!tipltc withdraw <ADDRESS> <AMOUNT>** : withdraw coins to specified address\n    **!tipltc <@user> <amount>** :mention a user with @ and then the amount to tip them\n    **!tipltc private <user> <amount>** : put private before Mentioning a user to tip them privately.\n\n    **<> : Replace with appropriate value.**',

bot/modules/ftcTipper.js

@@ -19,12 +19,7 @@ exports.tipftc = {
     paytxfee,
   process: async function (bot, msg, suffix) {
     let tipper = msg.author.id.replace('!', ''),
-      words = msg.content
-        .trim()
-        .split(' ')
-        .filter(function (n) {
-          return n !== '';
-        }),
+      words = msg.content.match(/\S+/g) || [],
       subcommand = words.length >= 2 ? words[1] : 'help',
       helpmsg =
         '__**Feathercoin (FTC) Tipper**__\nTransaction Fees: **' +

bot/modules/lbcTipper.js

@@ -19,12 +19,7 @@ exports.tiplbc = {
     paytxfee,
   process: async function (bot, msg, suffix) {
     let tipper = msg.author.id.replace('!', ''),
-      words = msg.content
-        .trim()
-        .split(' ')
-        .filter(function (n) {
-          return n !== '';
-        }),
+      words = msg.content.match(/\S+/g) || [],
       subcommand = words.length >= 2 ? words[1] : 'help',
       helpmsg =
         '__**LBRY Credit (LBC) Tipper**__\nTransaction Fees: **' +

bot/modules/protonTipper.js

@@ -19,12 +19,7 @@ exports.tipproton = {
     paytxfee,
   process: async function (bot, msg, suffix) {
     let tipper = msg.author.id.replace('!', ''),
-      words = msg.content
-        .trim()
-        .split(' ')
-        .filter(function (n) {
-          return n !== '';
-        }),
+      words = msg.content.match(/\S+/g) || [],
       subcommand = words.length >= 2 ? words[1] : 'help',
       helpmsg =
         '__**Proton (PROTON) Tipper**__\nTransaction Fees: **' +

bot/modules/pxcTipper.js

@@ -19,12 +19,7 @@ exports.tippxc = {
     paytxfee,
   process: async function (bot, msg, suffix) {
     let tipper = msg.author.id.replace('!', ''),
-      words = msg.content
-        .trim()
-        .split(' ')
-        .filter(function (n) {
-          return n !== '';
-        }),
+      words = msg.content.match(/\S+/g) || [],
       subcommand = words.length >= 2 ? words[1] : 'help',
       helpmsg =
         '__**Phoenixcoin (PXC) Tipper**__\nTransaction Fees: **' +

bot/modules/rvnTipper.js

@@ -19,12 +19,7 @@ exports.tiprvn = {
     paytxfee,
   process: async function (bot, msg, suffix) {
     let tipper = msg.author.id.replace('!', ''),
-      words = msg.content
-        .trim()
-        .split(' ')
-        .filter(function (n) {
-          return n !== '';
-        }),
+      words = msg.content.match(/\S+/g) || [],
       subcommand = words.length >= 2 ? words[1] : 'help',
       helpmsg =
         '__**Ravencoin (RVN) Tipper**__\nTransaction Fees: **' +

bot/modules/ufoTipper.js

@@ -19,12 +19,7 @@ exports.tipufo = {
     paytxfee,
   process: async function (bot, msg, suffix) {
     let tipper = msg.author.id.replace('!', ''),
-      words = msg.content
-        .trim()
-        .split(' ')
-        .filter(function (n) {
-          return n !== '';
-        }),
+      words = msg.content.match(/\S+/g) || [],
       subcommand = words.length >= 2 ? words[1] : 'help',
       helpmsg =
         '__**Uniform Fiscal Object (UFO) Tipper**__\nTransaction Fees: **' +

bot/modules/vtlTipper.js

@@ -19,12 +19,7 @@ exports.tipvtl = {
     paytxfee,
   process: async function (bot, msg, suffix) {
     let tipper = msg.author.id.replace('!', ''),
-      words = msg.content
-        .trim()
-        .split(' ')
-        .filter(function (n) {
-          return n !== '';
-        }),
+      words = msg.content.match(/\S+/g) || [],
       subcommand = words.length >= 2 ? words[1] : 'help',
       helpmsg =
         '__**Vertical (VTL) Tipper**__\nTransaction Fees: **' +