Store less zip tree transition information - #5006
Merged
Merged
Conversation
adamnovak
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg giraffechaining mode (-b hifi,-b r10,-b chaining-sr) memory & speed optimizations; no effect on outputDescription
This plucks out two optimizations I did in my MP chaining branch which can be easily inherited by the regular chaining.
max_indel_basesthreshold, then we don't save it in the first place.Combined, these mean we store the absolute minimum amount of transition info necessary in order to run chaining (the memory part) and thus have to construct & sort less data (the speed part).