surject: check anchor sliding on target paths - #5011
Draft
Sagorikanag wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
vg surject --max-slidenow detects slideable anchors using both theread sequence and the target-path sequence.
Description
The existing
--max-slidecheck pruned an anchor when the same sequenceoccurred at a nearby offset in the read. However, an anchor can also be
ambiguous because its reference sequence occurs again nearby on the path
being surjected to.
This change preserves the existing read-based check and adds a target-path
check. For every offset within
--max-slide:The target-path comparison is limited to the path currently being surjected
to. An anchor occurring on other graph paths does not affect this decision.
Both forward and reverse-strand anchors are handled.