Long read giraffe parameter smoothening - #5015
Open
faithokamoto wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg giraffe --max-chains-per-treeworks as documented (bugfix)vg giraffe --min-chainsis now--target-alignment-attemptsand has better documentationvg giraffechaining mode speedupDescription
First item on the list is what I mentioned in Slack about us accidentally passing
--max-alignmentsin thefind_best_chains()function call where we meant--max-chains-per-tree. Second is also something we talked about in Slack about a parameter that I didn't understand and messed with incorrectly. Third is that, since it's not necessary, we no longer passgap_open&gap_extendinto chaining (we now score transitions using Minimap2-style logged-gap scoring), andchain_items_dp()now only calculates the max DP cell ifshow_workis turned on since we don't really need it downstream and why not save ourselves yet another pass through the anchors. The only functionality change is to thesr-chainingpreset.