docs: onboarding document — Jinendran - #226
Open
Jinendran10 wants to merge 1 commit into
Open
Conversation
Onboarding document required before a first contribution PR, covering the six mandated sections. Section 4 documents eleven gaps, each verified against origin/main @ 1bd4599 with file paths and line ranges — including a total authentication bypass (routes/auth.ts:34-38 accepts the committed demo password for accounts that already have a real one), a route that ignores its :id parameter and returns the whole student collection, and the diagnostic path discarding both the Python pipeline's per-error analysis and the child's own answers. Section 5 maps every gap to a proposed fix. Section 6 records the work done during onboarding. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboarding document required before a first contribution PR. One file, documentation only:
Ideas/ONBOARDING-Jinendran.md.All six mandated sections are present and in the required order.
On section 4 (Gaps)
Eleven gaps, every one verified against
origin/main@1bd4599with file paths and line ranges rather than carried over from existing docs. The ones I would flag for attention first:backend/src/routes/auth.ts:36-38retries the committed demo password hash, and the guard isuser.passwordHash— so the demo password is accepted precisely when the user has set a real password of their own. No role exception, so this includes superadmin.SEED_DEMO_PASSWORD_HASHis defined twice (auth.ts:7hardcoded,db.ts:12-13environment-aware) and the login path imports the hardcoded one, so settingSEED_DEMO_PASSWORDchanges whatreseedwrites but not what login accepts.GET /api/students/:id/diagnostic-paper(routes/students.ts:60-125) never readsreq.params.idand returns the caller's whole scoped student list via an unboundedgetStudents().root_causes,levels_failed,performance_by_difficulty, all written byai-services/scripts/2_evaluate_child.pyand never read) and the child's own answers (noAnswerSubmissionis written for the one assessment that sets a child's initial level).pull_requesttrigger.On section 5 (Ideas)
Every gap maps to a proposed fix with an implementation approach. G1–G3 → I1, G4 → I2, G5/G6 → I3, G7 → I4, G8/G10 → I5, G9 → I6, G11 → I7.
On section 6 (Contribution)
Covers work done during onboarding, including a fix implementing part of I3. My Misconception Fingerprinting feature is described there but is not included in this PR — it is on a separate branch, since the instructions ask for the onboarding document before a first contribution PR. Paths belonging to that branch are marked as such in the document so no reviewer is sent to a file that isn't on
main.Happy to split any gap out into its own issue if that is more useful for tracking.