Feat : adaptive micro practice engine - #306
Conversation
…ation, bulk workflows, scheduling)
…, paper formatting fixes
…s count accuracy, dialog UX polish
…e Individual/Bulk badges, Fix composite generators ignoring requested question count in Micro-Practice
…names in pending papers, Auto-create PracticeSchedule for weak competencies on diagnostic submission, so they immediately appear in Due Today
…(dead inline duplicates vs routes/*.ts), port reconciliation logic into routes/students.ts, fix reconcile normalization bug
…-practice-engine # Conflicts: # frontend/src/components/Layout.tsx
Condenses our own multi-line explanatory comments down to 1-2 lines, keeping only the essential why. Pre-existing comments from other authors are untouched.
…ns in shared generators, fix questionCount metadata accuracy
|
Thank you for this, Ashish. I spent some time tracing the core logic in detail, including the schedule reconciliation, the spaced-repetition interval calculation, and the duplicate-question exclusion handling, rather than relying only on the PR description. The underlying design holds up well, and the problem this feature is trying to solve is an important one for the platform: turning a known weakness such as Fractions into repeated, targeted practice rather than waiting for the next broad diagnostic. There are two relatively contained changes I would request before merge.
At the moment, The manual flow also appears to search around The PDF-generation flow already seems to handle both of these concerns correctly through That would help ensure that both ways of delivering Micro-Practice use the same content source and the same progression logic.
The PR currently adds the A dedicated file such as I would also suggest moving I do not think either of these changes requires expanding this PR into the larger question-bank or misconception-mapping work already planned under the later milestones. Those are broader pieces of work and can remain separate. The requests here are mainly about making the two Micro-Practice delivery paths internally consistent and keeping the new feature aligned with the backend structure the repository is already moving toward. Overall, the scheduling and remediation flow here is thoughtfully designed, and I appreciate the amount of work that has gone into it. These changes would make the feature much easier to maintain and give us a cleaner foundation for the deeper concept-mastery and misconception work that follows. |
…d OCR pipeline changes
Moves all 15 /api/practice/* and /api/students/:id/micro-practice/* (plus weak-competencies, which shares a helper) routes out of index.ts's startServer() closure, matching the routes/students.ts pattern. calculateNextScheduleState moves into practiceScheduleService.ts, exported for direct unit testing, alongside the schedule logic it belongs with. Also includes a Tailwind conditional-class indentation fix in Layout.tsx left over from the earlier upstream merge. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013KRrvrZ4PuPmfheaxQpQey
|
@jgupta05072003-code Thank you for the detailed review, both requested changes are now complete:
Also merged in the latest main and resolved the resulting conflicts. Let me know if you'd like anything adjusted further. Thank you again for the thorough review! |
… redundant letter prefix from on-screen question text
…n and curriculum-levels features
What this PR does
Adds Micro-Practice - a spaced-repetition practice system that generates small, targeted printable papers for a student's specific weak competencies, tracks real difficulty progression as they improve, and provides a full workflow for teachers to evaluate completed papers.
What's included