docs: add React Router framework guide and improve contributing guide#191
Open
ChloeGarciaMillerand wants to merge 2 commits into
Open
docs: add React Router framework guide and improve contributing guide#191ChloeGarciaMillerand wants to merge 2 commits into
ChloeGarciaMillerand wants to merge 2 commits into
Conversation
✅ Deploy Preview for vite-pwa-org ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
FYI: react router v7 not yet supported, remix did a huge refactor, next pwa plugin v2 will allow us to use vite env. Api and we will provide a new package for it. Check this pr on my repo: userquin/vite-pwa-react-router#3 |
Author
|
Thanks for the clarification. I’ll keep following your work and future updates on this topic. Thanks again for your feedback and for maintaining the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add React Router Framework documentation and improve contributing guide
React Router Framework
As a React Router v7 user, I encountered some difficulties integrating Vite PWA, especially around the application entry point (root.tsx) and the preview setup, which did not work as expected for local testing.
I thought adding this documentation could help other developers facing similar issues.
Contributing Guide
I also spent some time understanding how to properly contribute to the existing documentation. This update aims to make the process clearer and help avoid similar confusion for future contributors.
Please feel free to let me know if any changes are needed in this PR. Thank you for your work!