Skip to content

🐛 Surface wrapped test command failures#295

Closed
Robdel12 wants to merge 1 commit into
mainfrom
rd/surface-run-command-failures
Closed

🐛 Surface wrapped test command failures#295
Robdel12 wants to merge 1 commit into
mainfrom
rd/surface-run-command-failures

Conversation

@Robdel12

Copy link
Copy Markdown
Contributor

Why

When vizzly run wraps a failing test command, the original command output is already streamed above the Vizzly summary. The final CLI message was still just Test run failed, which made CI failures feel like the CLI had swallowed the real error and left reviewers without a clear next step.

Approach

This keeps the existing streaming behavior intact and makes the final wrapper message explicit: the wrapped test command failed, which exit code it returned, and that the original failure is in the command output above.

That avoids adding buffering or replay behavior around child process output, which would be riskier for interactive test runners and TTY-sensitive tools.

Confidence

The focused run-command test covers the new failure message, and Biome passes on the touched CLI files.

@vizzly-testing

Copy link
Copy Markdown

Vizzly - Visual Test Results

CLI Reporter - Waiting for build

No builds received yet for this pull request.

CLI TUI - Approved

5 comparisons, no changes detected.

View build


rd/surface-run-command-failures · 07219050

@Robdel12

Copy link
Copy Markdown
Contributor Author

Closing this after re-checking the CI failure path. The CLI already inherits the wrapped command stdout/stderr; the missing failure details came from the wrapped command running Vite in silent mode, which was fixed in the Vizzly app scripts. This PR only improved the wrapper sentence, so it is not the right fix for the observed issue.

@Robdel12 Robdel12 closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant