fix(webrtc): wait for Node ICE gathering before sending SDP answer - #45
Merged
Merged
Conversation
Node runtime sets iceAnswerPolicy wait-gathering so relay candidates are
embedded in the SDP answer via gatheringComplete. Browser keeps
trickle-immediate; answer SDP is serialized as plain { type, sdp }.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production relay-only runners need
a=candidate(especiallytyp relay) in the SDP answer because the Node client does not trickle ICE candidates on the production signaling path. This adds an expliciticeAnswerPolicyonWebRtcRuntime:trickle-immediate— send the answer right aftersetLocalDescription; keep the existing Chrome gather race behavior.createNodeWebRtcRuntime):wait-gathering— awaitgatheringComplete()(node-webrtc-rust) orwaitForIceGatheringCompletefallback, then send a plain{ type, sdp: string }answer.Also hardens
onicecandidateserialization so a badtoJSONcannot silently drop trickle frames.Test plan
Verified locally:
npm test,npm run typecheck,npm run build(all exit 0).