Skip to content

docs(changelog): record the lint retired-stale fix#479

Open
luciferlive112116 wants to merge 1 commit into
vouchdev:testfrom
luciferlive112116:fix/lint-retired-stale
Open

docs(changelog): record the lint retired-stale fix#479
luciferlive112116 wants to merge 1 commit into
vouchdev:testfrom
luciferlive112116:fix/lint-retired-stale

Conversation

@luciferlive112116

@luciferlive112116 luciferlive112116 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

what changed

adds the ## [Unreleased]### Fixed changelog entry for the lint
retired-stale fix that landed in #484 (issue #478). changelog only — no
code change.

this pr originally carried the fix itself; #484 landed the same change
first, so it has been reduced to the one piece that wasn't merged with it.

why

CONTRIBUTING requires a CHANGELOG.md entry under ## [Unreleased] for
user-visible changes, and #484 shipped health.py + tests without one.
lint no longer emitting stale_claim warnings for retired claims is
user-visible — anyone parsing vouch lint output sees a different set of
findings. ### Fixed is what the next release notes are rolled from
(CONTRIBUTING §"Release checklist" step 2), so without this the change
ships undocumented.

what might break

nothing. documentation only — no code, no on-disk shape, no kb.*
behaviour.

tests

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 87bda201-f1bc-4dfa-adba-900b15f72354

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added docs documentation, specs, examples, and repo guidance tests tests and fixtures size: S 50-199 changed non-doc lines labels Jul 13, 2026
the fix landed in vouchdev#484 without a changelog entry, and the
`## [Unreleased]` / `### Fixed` section is what the next release notes
are rolled from — a user-visible behaviour change (lint stops emitting
`stale_claim` warnings for retired claims) would otherwise ship
undocumented.
@luciferlive112116 luciferlive112116 changed the title fix(health): exempt retired claims from the lint stale check docs(changelog): record the lint retired-stale fix Jul 15, 2026
@github-actions github-actions Bot removed the tests tests and fixtures label Jul 15, 2026
@luciferlive112116

Copy link
Copy Markdown
Contributor Author

#484 landed the same fix first, so i've rebased this onto current test
and dropped my duplicate health.py + test changes — they're already in.

what's left is just the changelog entry, which #484 didn't include. the
retired-stale exemption is user-visible (vouch lint stops emitting
stale_claim for retired claims) and ### Fixed is what the next release
notes get rolled from, so it seemed worth not losing. happy to close if
you'd rather fold it in elsewhere.

@github-actions github-actions Bot added size: XS less than 50 changed non-doc lines and removed size: S 50-199 changed non-doc lines labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs documentation, specs, examples, and repo guidance size: XS less than 50 changed non-doc lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant