prevent Unknown resource type error (issue #35)

[ttoohey]

No description provided.

[bastelfreak]

Hi @ttoohey, thanks for this patch. Are you able to provide a unit test to prove that this now compiles?

[alexjfisher]

It looks like #10 was completely broken when merged. Looks like a rebase or merge from master went wrong and undid part of the changes.

[alexjfisher]

I think the issue was #7 and #10 both were trying to fix the same issue.
#7 work starts
#10 work starts
#7 merged
#10 pull changes from master (including the #7 changes) and is then merged.

This PR undoes part of #10, but also leaves parts of it behind. Maybe we just revert #10 completely?
And apologies to all that PRs took so long before they were reviewed.

[alexjfisher]

I think I'd prefer reverting #10 ?
@bastelfreak ?

[alexjfisher]

@ttoohey Would you be able to try out #37 ? Thanks.

[ttoohey]

@bastelfreak - I'd like to have included a unit test, but I couldn't get past an error when trying to bundle install and I'm not very familiar with Ruby

@alexjfisher - yes, #37 solves my problem. I'm not sure it will solve what #10 was attempting (but this PR probably doesn't either).

[vox-pupuli-tasks]

Dear @ttoohey, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[vox-pupuli-tasks]

Dear @ttoohey, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks