Implement estimateTransactionFee - #13
Open
Keeqler wants to merge 3 commits into
Open
Conversation
vtnerd
requested changes
Aug 4, 2026
| std::sort(unspent_amounts.begin(), unspent_amounts.end(), std::greater<std::uint64_t>()); | ||
| std::uint64_t selected = 0; | ||
| std::size_t n_inputs = 0; | ||
| for (const std::uint64_t amt : unspent_amounts) |
Owner
There was a problem hiding this comment.
What to do if there isn't enough unspent coins for the tx? This interface doesn't allow for much - either an exception, a bogus small value for fee, or some bogus large value.
Contributor
Author
There was a problem hiding this comment.
Lmk if it looks ok now
vtnerd
requested changes
Aug 19, 2026
| } | ||
| } | ||
|
|
||
| if (!unspent_amounts.empty() && !covered) |
Owner
There was a problem hiding this comment.
Why !unspend_amounts.empty() ? Seems like the only condition should be !covered ??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.