Skip to content

fix(dialog): Added class for Entity Tweaks windows for 1.8.x - #351

Merged
anthonyronda merged 1 commit into
vttred:1.8.xfrom
bakbakbakbakbak:enhancement/test_helpers
Mar 27, 2023
Merged

fix(dialog): Added class for Entity Tweaks windows for 1.8.x#351
anthonyronda merged 1 commit into
vttred:1.8.xfrom
bakbakbakbakbak:enhancement/test_helpers

Conversation

@bakbakbakbakbak

Copy link
Copy Markdown
Collaborator

Putting these two in the same as it is just for convenience for testing purposes.

@bakbakbakbakbak bakbakbakbakbak changed the title Enhancement(test): ItemTypes helper & minor modification to Entity Tweaks Enhancement(test): ItemTypes helper & minor modification to Entity Tweaks for 1.8.x Feb 11, 2023
@bakbakbakbakbak bakbakbakbakbak changed the title Enhancement(test): ItemTypes helper & minor modification to Entity Tweaks for 1.8.x enhancement(test): ItemTypes helper & minor modification to Entity Tweaks for 1.8.x Feb 11, 2023
@anthonyronda

Copy link
Copy Markdown
Member

Could you describe what for, or provide an example of use, for the ItemTypes? Not opposed just interested. Perhaps the currently commented out Item CRUD tests? Or sheet-item-tests.ts?

@bakbakbakbakbak

bakbakbakbakbak commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator Author

Could you describe what for, or provide an example of use, for the ItemTypes? Not opposed just interested. Perhaps the currently commented out Item CRUD tests? Or sheet-item-tests.ts?

Mainly because it is being reused in a lot of the tests, and in case we need to add/remove item types later, one location would is simpler to maintain. That was the reasoning of moving this to testUtils.ts!

With the full test suite, including actors, it is reused here:
image

@anthonyronda

Copy link
Copy Markdown
Member

I saw it was cherry picked for #356 ? So is this still necessary here?

@bakbakbakbakbak

Copy link
Copy Markdown
Collaborator Author

I saw it was cherry picked for #356 ? So is this still necessary here?

Indeed, it is not necessary here if/when that gets merged! At the point I submitted this PR I hadn't started #356 yet.

@bakbakbakbakbak
bakbakbakbakbak force-pushed the enhancement/test_helpers branch from 9c33cea to dc94fff Compare March 3, 2023 15:23
@bakbakbakbakbak
bakbakbakbakbak force-pushed the enhancement/test_helpers branch from dc94fff to 06b6f65 Compare March 5, 2023 08:25
@bakbakbakbakbak

Copy link
Copy Markdown
Collaborator Author

Made this atomic, as part of it is included in #356 , making this just a fix for entity tweaks lacking class like other windows.

@bakbakbakbakbak bakbakbakbakbak changed the title enhancement(test): ItemTypes helper & minor modification to Entity Tweaks for 1.8.x fix(dialog): Added class for Entity Tweaks windows for 1.8.x Mar 5, 2023

@anthonyronda anthonyronda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthonyronda
anthonyronda merged commit ee94e17 into vttred:1.8.x Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants