Skip to content

build(deps): bump signal-hook from 0.3.18 to 0.4.4 - #101

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/signal-hook-0.4.4
Closed

build(deps): bump signal-hook from 0.3.18 to 0.4.4#101
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/signal-hook-0.4.4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bumps signal-hook from 0.3.18 to 0.4.4.

Changelog

Sourced from signal-hook's changelog.

0.4.4

  • Documentation about SIGBUS (#204).

0.4.3

  • Don't exclude .c files from release package.

0.4.2

  • Fix double-close on pipe unregister (#200).
  • Don't include development scripts in release package (195).

signal-hook-mio-0.3.0

signal-hook-tokio-0.4.0

signal-hook-async-std-0.4.0

  • Release to bump dependency on signal-hook.

0.4.1

  • Don't pin specific dependency versions accidentally.

0.4.0

  • Changed the low_level::pipe to look OwnedFd instead of IntoRawFd, to enforce ownership of the file descriptor (#196).

signal-hook-registry-1.4.8

  • Restore errno on signal handler exit (#194, #191).

signal-hook-registry-1.4.7

  • Using earlier monopolization to reduce binary size (#190).

signal-hook-mio-0.2.5

  • Allow mio 1.1

signal-hook-registry-1.4.6

  • Reword/improve the safety requirements docs for register (#178).

signal-hook-1.3.18

  • Release the special-case removal of AIX for top-level signal-hook too (#169, #176).

signal-hook-async-std-0.3.0

... (truncated)

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Sep 7, 2026
@dependabot
dependabot Bot requested a review from vyncint as a code owner September 7, 2026 10:57
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Sep 7, 2026
Bumps [signal-hook](https://github.com/vorner/signal-hook) from 0.3.18 to 0.4.4.
- [Changelog](https://github.com/vorner/signal-hook/blob/master/CHANGELOG.md)
- [Commits](vorner/signal-hook@v0.3.18...v0.4.4)

---
updated-dependencies:
- dependency-name: signal-hook
  dependency-version: 0.4.4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/cargo/signal-hook-0.4.4 branch from 3f88131 to 8b1bf86 Compare September 8, 2026 12:50
@vyncint

vyncint commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Reviewed and not merging this one — it costs a duplicate crate and buys nothing today.

What the lockfile in this diff actually says

signal-hook appears twice after the bump:

+[[package]]
+name = "signal-hook"
+version = "0.4.4"
...
-  "signal-hook",
+  "signal-hook 0.3.18",     # crossterm
+  "signal-hook 0.3.18",     # signal-hook-mio
+  "signal-hook 0.3.18",     # termwiz

Today there is one copy, shared:

$ cargo tree -i signal-hook --depth 3
signal-hook v0.3.18
├── crossterm v0.29.0
│   └── ratatui-crossterm v0.1.2
│       └── ratatui v0.30.2
├── mossaic v0.8.0
└── signal-hook-mio v0.2.5
    └── crossterm v0.29.0 (*)

crossterm 0.29 pins signal-hook 0.3, and ratatui 0.30 pins crossterm. So moving mossaic to 0.4 does not move the tree to 0.4 — it adds a second copy beside the first, and both get compiled into a release binary that this crate builds with lto = true.

Why that matters more than usual here

The comment immediately above the line this PR edits is the rationale for the version:

signal-hook … already in the tree at this version, since crossterm pulls it through ratatui for its event stream.

Being already in the tree is why 0.3 was chosen. Merging this would quietly falsify the comment explaining the choice, which is the kind of drift that survives for years because nothing checks it.

What would justify it

  • A security advisory against 0.3.18. There is none — cargo deny check advisories is clean.
  • An API mossaic needs. It uses three items, all unchanged across the major: consts::{SIGHUP, SIGINT, SIGTERM}, iterator::Signals::new, and low_level::emulate_default_handler (src/restore.rs).
  • crossterm moving to 0.4, at which point the bump is free again and the tree goes back to one copy. That is the real trigger, and it is not in our hands.

deny.toml has multiple-versions = "warn", so CI stays green either way — this is a judgement the check deliberately leaves to a person, and the judgement is: not yet.

Nothing wrong with the PR itself; the bot is doing its job. Closing so it stops being re-proposed weekly, and telling Dependabot to hold this major until there is a reason.

@dependabot ignore this major version

@vyncint

vyncint commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Closing per the review above — held until crossterm moves to signal-hook 0.4, at which point the bump costs nothing.

@dependabot dependabot Bot closed this Sep 8, 2026
@dependabot @github

dependabot Bot commented on behalf of github Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you about version 0.x.x again, unless you re-open this PR.

@dependabot
dependabot Bot deleted the dependabot/cargo/signal-hook-0.4.4 branch September 8, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant