Editorial: various typos found with cSpell - #2865
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
nschonni marked as non substantive for IPR from ash-nazg. |
jnurthen
left a comment
jnurthen
left a comment
There was a problem hiding this comment.
looks good. Lots of these are in comments or process documents but once this is changed see no reason not to merge
| // else if (commit.message.toLowerCase().includes("typo")) return false; | ||
| // else return true; | ||
| return !/^Merge pull|^tidy|^TRAVIS|^ADMIN|^Generated by|respec|(editorial)|.md|editorial|Editiorial|edtiorial|^chore|^refactor|^tests?|^docs|w3cgruntbot|index.html|typo|^nit/i.test( | ||
| return !/^Merge pull|^tidy|^TRAVIS|^ADMIN|^Generated by|respec|(editorial)|.md|editorial|Editorial|^chore|^refactor|^tests?|^docs|w3cgruntbot|index.html|typo|^nit/i.test( |
There was a problem hiding this comment.
remove this change. This is deliberately filtering out mispellings from the chaneglog
There was a problem hiding this comment.
No commits have the typo as far as search is seeing https://github.com/search?q=edtiorial+repo%3Aw3c%2Faria&type=commits&ref=advsearch
Correct spelling does have hits https://github.com/search?q=editorial+repo%3Aw3c%2Faria&type=commits&ref=advsearch
There was a problem hiding this comment.
daniel-montalvo
left a comment
daniel-montalvo
left a comment
There was a problem hiding this comment.
Thanks @nschonni
daniel-montalvo
changed the title
|
@nschonni Hope you don't mind me changing the PR title. It's kind of important for my own queries and I think this is more "editorial" than anything else. |
daniel-montalvo
moved this to Ready to merge
in ARIA Editorial (Spec Prose Updates) PR Tracking
|
@daniel-montalvo no problem. If you'd even prefer to cherry-pick and submit only certain parts, I don't mind. |
|
Hey @giacomo-petri This is probably one that you could review |
68fa9be to
0f99e8f
Compare
|
Everything looks fine. Just one question: "seperator" -> "separator" is currently listed as the computed role in the core-aam spec (https://www.w3.org/TR/core-aam-1.2/#role-map-separator-focusable). It's definitely a typo, but would this be considered editorial, or does it require the UA to double-check it first in implementations? Note: I also created a WPT locally, and all three major browsers are consistent in reporting "separator" Note 2: @daniel-montalvo @jnurthen, I'm also not sure what we decided about |
5 participants
Took a pass with cSpell and cleaned up a bunch of the things that it flagged.
Could break this up a bunch so that there is a PR per spec, but I figured I'd just open the big one first and then split it if needed.