Add default values to *Init dictionaries - #125
Merged
Merged
Conversation
Contributor
|
Thanks for the fix! |
beckysiegel
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 11, 2026
As per [1], the Init dictionaries for EditContext events should have default values specified. Update Blink's IDL to match the spec. There should be no behavior change here since the C++ implementations of the classes that take these Init dictionaries already initialized these fields to these same values. [1] w3c/edit-context#125 Change-Id: I957261be6cf658c9cda937cc11aa95637ee02b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7922898 Reviewed-by: Ashish Kumar <ashishkum@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1645423}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dictionaries for the constructors of EditContext objects are missing default values, so it's unclear what the corresponding attributes should be set to when they aren't passed. These are the defaults which Chrome uses, and they are very much what you would expect.
Closes #124.