Skip to content

Fix broken links to "layout viewport" #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tidoust wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Fix broken links to "layout viewport" #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@
, "geometry-1"
, "uievents"
, "infra"
, "input-events"]
, "input-events"
, "css-viewport"

@dandclark dandclark Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, "css-viewport"
, "cssom-view"

When this is css-viewport, the link currently resolves to https://www.w3.org/TR/css-viewport-1/#layout-viewport which doesn't actually have that definition. I think the issue is that the draft https://drafts.csswg.org/css-viewport/#layout-viewport defines the term so respec sees the linkage, but the published version https://www.w3.org/TR/css-viewport-1/ doesn't yet have it.

One option is to wait to land this PR until another version of css-viewport is published, at which point this link should be there. Another is to apply the suggestion to change it to cssom-view, which makes it resolve to published version of the spec this already links to (https://www.w3.org/TR/cssom-view-1/#layout-viewport), so we're at least not hardcoding the link anymore.

Or if there's a way to get respect to link to the draft version of css-viewport that'd work too, but I'm not sure if that can be done without hardcoding it.

I'm not sure which is better, maybe the editors of those specs have a recommendation? Or I'd be fine to just land a version of this now pointing to cssom-view-1 since the result is we still keep linking to the same spec for now, with a note to consider switching to cssom-view later if the published version of that spec ends up with a definition that's more applicable to what EditContext is doing with it.

, "css-values"]
};
</script>
</head>
Expand Down Expand Up @@ -139,13 +141,10 @@ <h4>EditContext state</h4>
[=Control bounds=], [=selection bounds=], and [=codepoint rects=] are given in the
<dfn>client coordinate system</dfn>, which is defined as a two-dimensional Cartesian
coordinate system (x, y) where the origin is the top-left corner of the
<a href="https://drafts.csswg.org/cssom-view/#layout-viewport">layout viewport</a>,
the x-axis points towards the top-right of the
<a href="https://drafts.csswg.org/cssom-view/#layout-viewport">layout viewport</a>,
and the y-axis points towards the bottom-left of the
<a href="https://drafts.csswg.org/cssom-view/#layout-viewport">layout viewport</a>.
The units of the client coordinate system are
<a href="https://drafts.csswg.org/css-values/#px">CSS pixels</a>.
[=layout viewport=], the x-axis points towards the top-right of the
[=layout viewport=], and the y-axis points towards the bottom-left of the
[=layout viewport=]. The units of the client coordinate system are
[=pixel unit|CSS pixels=].
</p>
<div class="note">
<p>
Expand Down
Loading