Fix 2010 ZCTA geometries for get_decennial() - #651
Open
NikKrieger wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
geometrycolumn was empty forget_decennial(geography = "ZCTA", year = 2010, geometry = TRUE).Despite the fact that tidycensus stripped the state prefix from ZCTA GEOIDs,
tigris::zctas(year = 2010)includes the prefix as well. As a result, theright_join()was not successfully joining the tidycensus numbers with the geometries.This PR adds code to strip the state prefix from the tigris output. It also adds tests.
Additionally, I changed
unique()toany()in theifstatements, because theoreticallyunique()could yield a vector of more than one element and break theifstatement, causing a confusing error message difficult to debug.