fix(orders): preserve unknown execution liquidity codes - #760
Open
faysou wants to merge 1 commit into
Open
Conversation
- Preserve unsupported wire codes as Liquidity::Unknown - Keep wire code zero mapped to Liquidity::None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map the documented execution liquidity codes as before, including wire code zero as
Liquidity::None. Preserve every other value asLiquidity::Unknown(i32)so callers can log, store, or reject an unsupported code without silently treating it as missing data.flowchart LR Wire[Execution liquidity code] --> Known{Code 0 to 3?} Known -- Yes --> Variant[Known Liquidity variant] Known -- No --> Unknown[Liquidity::Unknown with original code]The conversion remains infallible while retaining the wire value for forward compatibility.
Testing
cargo test -p ibapi --features sync.