fix(connection): retry failed session establishment - #761
Open
faysou wants to merge 1 commit into
Open
Conversation
- Retry when TCP reconnects before the TWS session is ready - Cover sync and async paths with transient handshake tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the sync and async reconnect loops active when the socket reopens but session establishment fails. This covers the interval where TWS accepts TCP connections before its API handshake is ready, such as during an automated restart.
stateDiagram-v2 [*] --> ReconnectSocket ReconnectSocket --> EstablishSession: socket connected ReconnectSocket --> Backoff: socket error EstablishSession --> Connected: session ready EstablishSession --> Backoff: handshake or startup error Backoff --> ReconnectSocket: attempts remain Backoff --> Failed: attempts exhaustedA reconnect succeeds only after the complete session is ready. Transient establishment failures consume an attempt and follow the existing backoff policy.
Testing
cargo test -p ibapi --features sync.