DSA Info page#1128
Merged
Merged
Conversation
|
Deployment previews on netlify for branch
|
Merged
dati18
reviewed
Jun 5, 2026
dati18
left a comment
dati18
left a comment
Contributor
There was a problem hiding this comment.
I added a few comments but the e2e test is still "red" so I will move this back to TODO
outdooracorn
previously requested changes
Jun 5, 2026
outdooracorn
left a comment
outdooracorn
left a comment
Member
There was a problem hiding this comment.
Looking good so far. Found a few issues and differences from the Figma design.
outdooracorn
reviewed
Jun 8, 2026
rosalieper
approved these changes
Jun 8, 2026
rosalieper
left a comment
rosalieper
left a comment
Contributor
There was a problem hiding this comment.
I am happy with this change being merged once the linting is fixed
deer-wmde
added a commit
that referenced
this pull request
Jun 11, 2026
This change came up with #1128 and I put it in its own PR because #1130 also needs this This fix addresses several things: 1. scroll to the top of the page after following an internal page link 2. making on-page anchor-links (#) work specified with vue router-link https://phabricator.wikimedia.org/T408254 https://phabricator.wikimedia.org/T420575
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T408254
Bug: T408254