Add @psalm-pure to count assertion methods#355
Open
devbanana wants to merge 1 commit intowebmozarts:masterfrom
Open
Add @psalm-pure to count assertion methods#355devbanana wants to merge 1 commit intowebmozarts:masterfrom
devbanana wants to merge 1 commit intowebmozarts:masterfrom
Conversation
Mark count(), minCount(), maxCount(), and countBetween() as pure so Psalm permits their use in pure contexts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
@psalm-puretocount(),minCount(),maxCount(), andcountBetween(). Most other methods have it already but this was being handled as maybe impure by PHPStan on a project I'm working on so thought I'd add it.