sync xhr: don't call send send() at all as at is may deadlock replayweb.page app - #236
Merged
Conversation
ikreymer
commented
Aug 20, 2026
ikreymer
commented
Member
- the fetch() is handled async anyway and the request will fail to reach service worker so should return early
- follow-up to Handle Sync XHR in Service Worker via async cache + reload #205
- fixes [Replay Bug]: Sync XHR can lock up app replayweb.page#548
…eb.page app. - the fetch() is handled async anyway and the request will fail to reach service worker so should return early - follow-up to #205 - fixes webrecorder/replayweb.page#548
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.