feat: add support for aws-lc-rs alongside ring#95
Open
sshockwave wants to merge 2 commits into
Open
Conversation
996658c to
74f5fed
Compare
Author
|
Another way we could deal with the testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
Part of webrtc-rs/webrtc#801
The roadmap listed post-quantum support in the "Future Exploration (Beyond 2027)" section. However, I think support for
aws-lc-rsshould gain more priority not because quantum computer is going to be realized anytime soon, but because the ecosystem (e.g.reqwest,rustls) is migrating towardsaws-lc-rsby default. Requiring downstream crates to include two crypto providers is not a good idea. There were also discussions thatringwas probably not intended for production use.Crate
rtc-iceandrtc-turnare also affected by the feature because they depend onrtc-stun, but I'm not sure I should add feature gates just to enable/disable the feature of a dependency. It seems recommended here but it is verbose and we seldom use these crates on their own anyway.Test commands:
By the way, will a similar PR to v0.17.x be accepted?