Fix backwards test of element's dirty value flag. - #12606
Merged
Conversation
This comes from whatwg#12065, whose motivation is in whatwg#12057. I believe this test of the dirty value flag is backwards. I think it was originally the right way (to fix whatwg#12057) around but was inadvertently inverted in whatwg@b213624
Member
|
This looks correct to me, but I'll let @saschanaz confirm just in case. |
saschanaz
self-requested a review
June 23, 2026 07:23
saschanaz
reviewed
Jun 27, 2026
| <ol> | ||
| <li><p>If <var>element</var>'s <span data-x="concept-fe-dirty">dirty value flag</span> is | ||
| true, then return the result of <span | ||
| false, then return the result of <span |
Member
There was a problem hiding this comment.
Hmm. But I think the original intent of putting true here is to make it "if true then X, otherwise Y"... Should we reverse the order while we are at it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from #12065, whose motivation is in #12057. I believe this test of the dirty value flag is backwards. I think it was originally the right way (to fix #12057) around but was inadvertently inverted in b213624
cc @saschanaz
/input.html ( diff )