Add assertion for ancestorOrigins - #12630
Open
TimvdLippe wants to merge 2 commits into
Open
Conversation
This is not referenced in the algorithm and instead parentDoc is used.
Contributor
Author
|
Hm, this line probably needs to be |
Contributor
Author
|
Relevant Servo PR that uncovers these issues: servo/servo#46056 |
Member
Yes that can be added. |
zcorpan
approved these changes
Aug 5, 2026
Contributor
Author
|
Do you want me to make that change in this PR (and thus make it a normative change) or in a separate PR? |
Member
|
@TimvdLippe either is OK. |
It can be `null`, as initially "internal ancestor origin objects" is `null` and is only initialized later. The assertion makes sure that it happens first in the parent and then in the child.
TimvdLippe
changed the title
Contributor
Author
|
All right done 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be
null, as initially "internal ancestor origin objects"is
nulland is only initialized later. The assertion makes surethat it happens first in the parent and then in the child.
The previous step referenced a variable that is no longer
present in the algorithm after e161310
(See WHATWG Working Mode: Changes for more details.)
/dom.html ( diff )