Positional HTML methods - #12753
Open
noamr wants to merge 6 commits into
Open
Conversation
6 tasks
5 tasks
noamr
force-pushed
the
noamr/positional-html
branch
2 times, most recently
from
August 6, 2026 10:40
ee46eb1 to
b48a945
Compare
zcorpan
reviewed
Aug 10, 2026
noamr
force-pushed
the
noamr/positional-html
branch
from
August 12, 2026 13:25
f9a87e5 to
d256495
Compare
noamr
force-pushed
the
noamr/positional-html
branch
from
August 24, 2026 09:45
53adea8 to
01fc7bc
Compare
Contributor
Author
|
Fixes from Opus review: Blockers
Suggestions
Nits
|
noamr
force-pushed
the
noamr/positional-html
branch
3 times, most recently
from
August 24, 2026 12:41
dec53b2 to
73e73db
Compare
noamr
force-pushed
the
noamr/positional-html
branch
from
August 25, 2026 08:18
73e73db to
0c5b590
Compare
noamr
force-pushed
the
noamr/positional-html
branch
from
August 25, 2026 14:38
0c5b590 to
b21b5d3
Compare
noamr
force-pushed
the
noamr/positional-html
branch
2 times, most recently
from
August 26, 2026 15:13
d7c9a5e to
f23f3cf
Compare
noamr
force-pushed
the
noamr/positional-html
branch
from
August 26, 2026 19:48
f23f3cf to
ee138bf
Compare
noamr
force-pushed
the
noamr/positional-html
branch
from
August 28, 2026 12:34
ee138bf to
98ce634
Compare
zcorpan
requested changes
Aug 31, 2026
noamr
force-pushed
the
noamr/positional-html
branch
from
September 1, 2026 15:11
98ce634 to
c5acf55
Compare
noamr
force-pushed
the
noamr/positional-html
branch
from
September 1, 2026 20:38
50d9679 to
8189f57
Compare
zcorpan
approved these changes
Sep 1, 2026
noamr
force-pushed
the
noamr/positional-html
branch
3 times, most recently
from
September 3, 2026 20:52
fd51016 to
4bb4e15
Compare
zcorpan
approved these changes
Sep 4, 2026
…DocumentFragments
noamr
force-pushed
the
noamr/positional-html
branch
from
September 4, 2026 16:09
4bb4e15 to
c74d16b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
appendHTML,prependHTML,beforeHTML,afterHTML, andreplaceWithHTML, alongside their*Unsafevariants.Use 3 helper algorithms for HTML insertion (pre-insert/replace/set), and call those from the appropriate web-exposed method.
ChildNodemethods fail silently when the child has no parent, like their equivalent DOM methods,and fails with a
HierarchyRequestErrorfor an invalid parent. Note that a direct child of atemplateelement is considered an invalid parent, as setting HTML totemplateelements would affect itscontentrather than its children.Renamed "set and filter HTML" to "filter and set HTML" to be more consistent with the order of operations and with the newly added helper methods.
Closes #10122
/dynamic-markup-insertion.html ( diff )
/infrastructure.html ( diff )
/system-state.html ( diff )