Skip to content

Only nullify the navigation API state when cross-document - #12838

Open
noamr wants to merge 3 commits into
mainfrom
noamr/nav-restore
Open

Only nullify the navigation API state when cross-document#12838
noamr wants to merge 3 commits into
mainfrom
noamr/nav-restore

Conversation

@noamr

@noamr noamr commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

traversal is used for same-document traverse navigations, as well as any cross-document navigation.

Nullifying the ongoing navigate event + method tracker should only take place when it's an actual cross-doc navigation.

This "ongoing navigation" change should change the state without aborting the current navigation.

Closes #12832

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )

@noamr noamr changed the title Noamr/nav restore Only nullify the navigation API state when cross-document Aug 25, 2026
@noamr
noamr force-pushed the noamr/nav-restore branch from 6d8951e to 9e55ef5 Compare August 25, 2026 10:54
@noamr

noamr commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@shannonbooth can you verify plz?

Comment thread source Outdated
@shannonbooth

Copy link
Copy Markdown
Member

This didn't show nicely in the comment since I suppose I commented just out of the context, but I'm referring to the step:

 <li><p><span>Set the ongoing navigation</span> for <var>navigable</var> to "<code
data-x="">traversal</code>".</p></li>

@noamr

noamr commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

How is it now @shannonbooth ?

@shannonbooth shannonbooth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, looks good to me!

@noamr

noamr commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

@zcorpan I don't have merge rights, mind helping out? Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

"nullify ongoing navigate event" step breaks same-document navigations

3 participants