Allow a Window as the target of "fire a focus event" - #12875
Open
zcorpan wants to merge 2 commits into
Open
Conversation
"Fire a focus event" was defined as taking an element, but the focus update steps invoke it with a `Window` object when the entry is a `Document`, and a `Window` has no node document to get the `view` attribute's value from. Fixes #12866.
Member
|
While you're here: I'm not too fond of the single-letter variables |
Member
Author
|
@annevk no, it's only called from focus update steps with either an element or a |
Member
Author
|
Are WebKit and Chromium ok with switching from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Fire a focus event" was defined as taking an element, but the focus update steps invoke it with a
Windowobject when the entry is aDocument, and aWindowhas no node document to get theviewattribute's value from.Fixes #12866.
(See WHATWG Working Mode: Changes for more details.)