Trigger media element resource selection algorithm from source element moving steps - #12880
Open
lukewarlow wants to merge 1 commit into
Open
Trigger media element resource selection algorithm from source element moving steps#12880lukewarlow wants to merge 1 commit into
lukewarlow wants to merge 1 commit into
Conversation
Contributor
|
@lukewarlow you asked for a review but it's still a draft... (?) |
Member
Author
|
Apologies I didn't think it would ping you till I marked it as ready. I'll let you know once it's ready. |
lukewarlow
marked this pull request as ready for review
September 3, 2026 13:21
Member
Author
|
Okay I've written tests as part of my WebKit PR (linked to the export above). I think this single line should be the only change needed. |
Member
Author
|
I'm guessing regarding implementor interest the fact chrome and firefox already implement this is enough? |
noamr
approved these changes
Sep 3, 2026
lukewarlow
added a commit
to lukewarlow/WebKit
that referenced
this pull request
Sep 3, 2026
https://bugs.webkit.org/show_bug.cgi?id=320463 Reviewed by NOBODY (OOPS!). Updates the moving steps for HTMLSourceElement to handle media elements and the model element. The HTML spec doesn't include these as the model element isn't defined and there's a spec bug regarding media elements. Spec bug: whatwg/html#12879 Spec PR: whatwg/html#12880 Tests: imported/w3c/web-platform-tests/dom/nodes/moveBefore/resource-selection-move-source-between-media-elements.html imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-audio.html imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-in-div.html imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-in-namespace.html imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-not-in-document.html imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source.html * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-audio-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-audio.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-in-div-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-in-div.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-in-namespace-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-in-namespace.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-not-in-document-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source-not-in-document.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-move-source.html: Added. * LayoutTests/model-element/model-element-source-expected.txt: * LayoutTests/model-element/model-element-source.html: * Source/WebCore/html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::movingSteps):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger media element resource selection algorithm from source element moving steps
Fixes #12879
(See WHATWG Working Mode: Changes for more details.)