Add check for OVERPASS_DIFF_URL in rules_loop.sh, removing irrelevant rules update in case where there are no updates#163
Open
XPav wants to merge 1 commit intowiktorn:masterfrom
Conversation
arnesetzer
reviewed
Apr 24, 2026
| sleep "$SLEEP_TIME" | ||
| if [[ -z "${OVERPASS_DIFF_URL}" ]]; then | ||
| echo "OVERPASS_DIFF_URL is not set - updates disabled, assuming areas created on init, sleeping forever" | ||
| sleep infinity |
Contributor
There was a problem hiding this comment.
Is there a reason why the command should sleep endlessly instead of exiting with break?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates the changes discussed in #158.
With no OVERPASS_DIFF_URL defined, the area rules created in docker-entrypoint.sh will always be good. The update call in rules_loop.sh is not needed and chews up resources with no effect.