fix: settings page vertical text misalignment (#31) - #47
Closed
eagleLiu82 wants to merge 2 commits into
Closed
Conversation
Toggle and checkbox labels in the settings drawer could shrink to
one-character columns and render their text vertically on the right edge
of the card: the global input { width: 100% } rule forced full-width
checkboxes inside flex rows, squeezing the label span to min-content.
- auto-size the settings-inline-toggle and zhizi-paid-confirm checkboxes
- let the label span fill the remaining width and wrap horizontally
- keep settings ghost/primary buttons and zhizi action buttons from
wrapping vertically (nowrap + flex-wrap)
- add a contract regression test for the one-line label layout
Verified: 244 tests, typecheck, production build.
- settings page alignment fix for issue wimi321#31 (checkbox toggles no longer render their labels as vertical one-character columns) - bump version to 0.4.21 and add multilingual release notes - update NVIDIA release-asset contract to the current model-selection mechanism (prepare:katago-transformer) used by the release workflow
Owner
|
Thank you @eagleLiu82 for carrying this fix and documenting the root cause. I reviewed the branch and integrated the focused settings-layout change through #48, then added real Electron visual QA, compact-window checks, and geometry validation across all seven supported locales. #48 is now merged.\n\nI intentionally excluded the unrelated 0.4.21 version bump, release notes, local tag preparation, and NVIDIA release-script changes so this UI fix could land independently and safely. Closing this PR as superseded by #48. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkbox labels could collapse to a single-character column and render
vertically on the right edge of the settings card.
input { width: 100% }rule stretched checkboxesacross the whole flex row and squeezed the label span to its minimum content
width (one CJK character). The checkbox is now auto-sized (16×16) and the
label span fills the remaining width via
flex: 1 1 auto; min-width: 0.white-space: nowrapto settings action buttons plusflex-wrapon Zhiziaction rows so button labels can never wrap vertically again.
notes (
docs/RELEASE_NOTES_v0.4.21.md), and syncs the NVIDIA release-assetcontract to the current
prepare:katago-transformermodel-selectionmechanism used by the release workflow.
Verification
pnpm typecheckpnpm buildpnpm test— 244/244 passing (incl. new regression test)node scripts/check_release_notes_i18n.mjs— multilingual release notes OK for v0.4.21node scripts/check_no_lite_release_assets.mjsnode scripts/check_nvidia_release_assets.mjsauto-optimize toggle renders a 16×16 checkbox with one-line horizontal
label text
Notes
b42ebf3(fix) and7126632(chore: prepare GoAgent v0.4.21 release).v0.4.21is created locally; push it after merge to trigger the release workflow.machine.