feat: implement SyncServicesUseCase to sync services from backend and update ObserveAllServicesUseCase to avoid network calls#4750
Open
MohamadJaara wants to merge 1 commit intodevelopfrom
Conversation
… update ObserveAllServicesUseCase to avoid network calls
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4750 +/- ##
========================================
Coverage 50.73% 50.74%
========================================
Files 603 603
Lines 21518 21522 +4
Branches 3344 3345 +1
========================================
+ Hits 10917 10921 +4
Misses 9614 9614
Partials 987 987
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
saleniuk
reviewed
Apr 30, 2026
| } else { | ||
| if (!servicesSynced) { | ||
| servicesSynced = true | ||
| launch { syncServices() } |
Contributor
There was a problem hiding this comment.
In that case, shouldn't we wait until services are synced instead of launching sync in a coroutine and then returning services while it's still syncing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
ObserveAllServicesUseCase only return after a remote API update even tho the list of bots is
Causes (Optional)
the use case will update first and then return
Solutions
split it into ObserveAllServicesUseCase and SyncServicesUseCase and call SyncServicesUseCase from the view model when needed to update
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.