feat: list of call participants [WPB-1057]#4762
Conversation
…ols-as-bottom-sheet
…ols-as-bottom-sheet
…ols-as-bottom-sheet
…sheet' into feat/call-participants-list
saleniuk
changed the base branch from
feat/calling-controls-as-bottom-sheet
to
develop
…ols-as-bottom-sheet
…ols-as-bottom-sheet
…sheet' into feat/call-participants-list # Conflicts: # app/src/main/kotlin/com/wire/android/ui/calling/ongoing/OngoingCallScreen.kt
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4762 +/- ##
===========================================
- Coverage 51.00% 51.00% -0.01%
===========================================
Files 605 606 +1
Lines 20996 20998 +2
Branches 3388 3388
===========================================
+ Hits 10709 10710 +1
- Misses 9281 9282 +1
Partials 1006 1006
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…ants-list # Conflicts: # app/src/main/kotlin/com/wire/android/ui/calling/ongoing/OngoingCallScreen.kt
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .height(0.dp) | ||
| .zIndex(1f) // ensure the section header is above the participant items when scrolled |
There was a problem hiding this comment.
Instead of of simulating sticky header, can use LazyColum with stickyHeader
LazyColumn {
stickyHeader {
SectionHeader(...)
}
items(...) { ... }
}
There was a problem hiding this comment.
It's not simulating the sticky header, it's actually a different intention than a sticky header. It handles the visuals of the whole list scroll, so it cannot be a part of the list as a sticky header, it needs to stay above the list, so in column it will be drawn first, that's why zIndex is used so that the background of the list doesn't cover the shadow elevation that this element creates.
|
2 participants
https://wearezeta.atlassian.net/browse/WPB-1057
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
As a Wire user on new Android I want to be able to see who is in the group call.
Solutions
Implemented a
ParticipantListwhich consists ofParticipantItem, and added it to the draggable bottom sheet ofOngoingCallScreen.Dependencies (Optional)
Needs releases with:
Testing
How to Test
Start or join a call and open the bottom sheet (drag or click on the handle).
Attachments (Optional)
Screen_recording_20260427_150423.mp4
Screen_recording_20260427_163714.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.