test: stabilize Okta SSO backup flow [WPB-25072]#4766
Merged
Conversation
MohamadJaara
approved these changes
Apr 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4766 +/- ##
========================================
Coverage 51.00% 51.00%
========================================
Files 605 605
Lines 20996 20996
Branches 3388 3388
========================================
Hits 10709 10709
Misses 9281 9281
Partials 1006 1006 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
yamilmedina
reviewed
Apr 29, 2026
…core/pages/SettingsPage.kt Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
yamilmedina
approved these changes
May 4, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-25072
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Fix the Okta SSO backup setup flow by using the same shared OktaApiClient throughout app creation, user creation, and assignment.
Update OktaApiClient.createUser(...) to return the created Okta user id so the test flow can use it immediately.
Add direct Okta app assignment with assignUserToApplication(userId) instead of relying on indirect propagation.
Remove the old indirect Okta propagation wait by deleting waitForAppGroupLink(...) and the extra warm-up sleep.
Tighten Okta retry handling so we only retry retryable failures, especially transient 429 responses, and respect Retry-After.
Make Okta cleanup in SSODeviceBackup best-effort with runCatching { oktaApiClient.cleanUp() } so teardown is less hard.
Pre-grant Android 13+ notification permission during test setup through PermissionUtils, while keeping the notification dialog tap as a fallback if the dialog still appears.
Keep the backup settings navigation more resilient by retrying the menu click until the backup page is detected.
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Stabilized the Android SSO backup test flow by fixing the Okta setup path: created Okta users are now assigned directly to the Okta app, and the old propagation wait/sleep logic was removed.
Improved test reliability around first-time setup by pre-granting Android notification permission during setup, keeping the UI permission tap as a fallback, and making the backup settings navigation and Okta cleanup less hard.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.