Enhance alphaBetaMasses with velocity-dependent final mass computation#63
Conversation
This update extends alphaBetaMasses by supporting the full alpha-beta final-mass solution when both initial and final velocities are provided. The previous asymptotic approximation is retained for backward compatibility when velocity information is unavailable. Additional improvements include: - Input validation for alpha, beta, mu, density, drag parameter, shape coefficient, and velocities. - Optional verbose output summarizing the adopted parameters and resulting mass estimates. - Expanded documentation.
|
Thanks for the PR — the velocity-dependent final-mass extension is a useful addition and the underlying math is correct (it's the standard Gritsevich dimensionless mass equation, with the old 1. Duplicate function definition (blocking). The new 2. Feature isn't wired into the CLI. The only callers are in the 3. Minor style. Trailing whitespace on several blank lines (docstring opener, before Once the duplicate is removed and the velocities are plumbed into the main block, this is good to go. |
|
Thanks for the review. The duplicate alphaBetaMasses definition has been removed and only the updated implementation remains. The CLI has been updated to use the terminal velocity predicted by the fitted alpha-beta solution and now passes vel_init and vel_end to alphaBetaMasses, so the full formulation is exercised directly from the command-line tool. Additional updates include:
|
This update extends alphaBetaMasses() by supporting the full alpha-beta final-mass solution when both initial and terminal velocities are provided. The previous asymptotic approximation is retained for backward compatibility when velocity information is unavailable.
The new functionality has also been integrated into the command-line interface, using the terminal velocity predicted by the fitted alpha-beta solution to ensure consistency when calculating masses with the general alpha-beta formulation.
Additional improvements include: